Skip to content

FoundationEssentialsTests: skip distant{Future,Past} tests on Windows #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

compnerd
Copy link
Member

The MSVC libc does not properly handle dates that are far out from the Unix epoch. For the purposes of allowing the test suite to pass on CI, skip these tests on Windows.

@compnerd
Copy link
Member Author

@swift-ci please test

@jmschonfeld jmschonfeld requested a review from itingliu June 13, 2024 15:55
@compnerd compnerd requested a review from parkera June 14, 2024 04:38
The MSVC libc does not properly handle dates that are far out from the
Unix epoch. For the purposes of allowing the test suite to pass on CI,
skip these tests on Windows.
@compnerd
Copy link
Member Author

@swift-ci please test

@jmschonfeld
Copy link
Contributor

@swift-ci please test macOS platform

@jmschonfeld jmschonfeld merged commit 9f3a74b into swiftlang:main Jun 14, 2024
2 checks passed
@compnerd compnerd deleted the date branch June 14, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants