Skip to content

Create benchmarks for base64 #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

fabianfett
Copy link
Contributor

Motivation

We love benchmarks. In order to ensure that our base64 performance does not regress we should have a bunch of benchmarks that test different aspects. Since we will have a bunch of those in the future lets get them into a separate target.

Changes

  • Create Base64Benchmarks target
  • Add Base64 benchmarks
    • Use scaling factor one if the example data is sufficiently large (1MB)
    • Use scaling factor kilo if the example data is so small that measuring perfs overhead is to large (mostly in the jwt head examples)

Result

We have baselines to test against.

@kperryua
Copy link
Contributor

@swift-ci test

1 similar comment
@parkera
Copy link
Contributor

parkera commented Sep 30, 2024

@swift-ci test

@parkera
Copy link
Contributor

parkera commented Sep 30, 2024

Oops - @kperryua already did that 😛

@parkera
Copy link
Contributor

parkera commented Sep 30, 2024

Looks good to me. Will merge soon after I make sure we don't conflict with other benchmark work.

@parkera
Copy link
Contributor

parkera commented Sep 30, 2024

Thanks so much @fabianfett !

@parkera parkera merged commit bdad47a into swiftlang:main Oct 1, 2024
3 checks passed
@fabianfett fabianfett deleted the ff-base64-benchmark branch October 1, 2024 21:09
cthielen pushed a commit to cthielen/swift-foundation that referenced this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants