Skip to content

Guard old behavior in URL tests #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

jrflat
Copy link
Contributor

@jrflat jrflat commented Oct 9, 2024

Add guards to make these tests compatible with both the old and new URL implementation.

@jrflat jrflat requested review from parkera and jmschonfeld October 9, 2024 19:05
@jrflat
Copy link
Contributor Author

jrflat commented Oct 9, 2024

@swift-ci please test

@jrflat jrflat force-pushed the url-test-compatibility branch from a69aab7 to dd1aa90 Compare October 9, 2024 20:00
@jrflat
Copy link
Contributor Author

jrflat commented Oct 9, 2024

The .path check in the test wasn't correct on Windows since we now strip the leading slash from drive letter paths. Should be fixed now.

@jrflat
Copy link
Contributor Author

jrflat commented Oct 9, 2024

@swift-ci please test

@jrflat jrflat merged commit 33a49e5 into swiftlang:main Oct 9, 2024
3 checks passed
cthielen pushed a commit to cthielen/swift-foundation that referenced this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants