WiX: drop dependency on votive #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We would previously depend on votive to provide the versioned non-isolated installation of the `Wix.targets` project for the wix targets definitions. Instead update the wixproj files to scan both the non-isolated and the isolated installations to enable us to build without the votive dependency. This allows us to reduce another dependency on Visual Studio towards just the build tools.
shahmishal
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would previously depend on votive to provide the versioned
non-isolated installation of the
Wix.targetsproject for the wixtargets definitions. Instead update the wixproj files to scan both the
non-isolated and the isolated installations to enable us to build
without the votive dependency. This allows us to reduce another
dependency on Visual Studio towards just the build tools.