Move installed XCTest.swiftmodule up one directory on Windows #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tristanlabelle
requested review from
shahmishal,
tomerd and
compnerd
as code owners
compnerd
requested changes
Mar 7, 2023
compnerd
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The layout of the XCTest directories on Windows is currently inconsistent between local builds and installed builds. This change resolves the inconsistency by updating swiftmodule directory location for XCTest from:
XCTest\usr\lib\swift\windows\%ARCH%\XCTest.swiftmoduleTo
XCTest\usr\lib\swift\windows\XCTest.swiftmoduleThis allows us to use the same include path on all architectures and matches other standard modules. SPM was previously updated accordingly here: swiftlang/swift-package-manager#4300 but the related #119 did not update the paths for
XCTest.