Skip to content

[6.0] WiX: add SwiftMacros.dll to the image #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2024

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented May 15, 2024

Cherry-pick #295 into release/6.0

  • Explanantion: This adds an additional DLL to the Windows toolchains. 'SwiftMacros.dll' includes macro implementations for stdlib. e.g. 'TaskLocal'
  • Scope: Standard library macros in Windows toolchains
  • Risk: Low. Just adding a DLL where it was supposed to be.
  • Testing: Locally confirmed that stdlib macros TaskLocal work
  • Issue: rdar://128092675
  • Reviewer: @compnerd

This adds an additional DLL to the image. 'SwiftMacros.dll' includes
macro implementations for stdlib. e.g. 'TaskLocal'

(cherry picked from commit 51d4aa8)
rdar://128092675
@rintaro rintaro requested a review from bnbarham May 15, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants