[CentOS 8] Dont patch any files and start building ninja #31
Conversation
|
@shahmishal #30 haha :D |
|
there is some overlap but also looks like you were able to get rid from more patches. so either we combine into one or we merge one then rebase the other |
Haha, I thought we talked offline about this yesterday. I might have miss understood who is working on it. |
no worried lets take your and we can rebase mine with the additional fixes for tarball names on top |
Open to either PR :) |
lets start with yours, added some comments inline |
| @@ -22,9 +22,6 @@ RUN yum-builddep -y /root/rpmbuild/SPECS/swift-lang.spec | |||
| # Get the sources for Swift as defined in the spec file | |||
| RUN spectool -g -R /root/rpmbuild/SPECS/swift-lang.spec | |||
|
|
|||
| # Add the patches | |||
| ADD patches/*.patch /root/rpmbuild/SOURCES/ | |||
There was a problem hiding this comment.
keep this in case we have patches in the future
There was a problem hiding this comment.
We should avoid patches, and have this resolved before release.
There was a problem hiding this comment.
sure we can add it back if we need it
shahmishal
force-pushed
the
dont-patch-and-build-ninja
branch
from
f236d35 to
8b0ca56
Compare
|
We still need two patches:
This will fix the Swift patch - swiftlang/swift#39614 |
No description provided.