WiX: remove references to DEVTOOLS_ROOT
#347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the Windows build has evolved, we have built up a complete toolchain image and removed the need for the separate `DEVTOOLS_ROOT`. This simplifies the packaging manifest and associated MSBuild files.
etcwilde
approved these changes
Nov 20, 2024
compnerd
added a commit
to compnerd/swift-build
that referenced
this pull request
Nov 20, 2024
Remove the use of the `DEVTOOLS_ROOT` property when building the installer MSIs. References to this have been removed from the WiX projects as of swiftlang/swift-installer-scripts#347.
compnerd
added a commit
to compnerd/apple-swift
that referenced
this pull request
Nov 20, 2024
This property was unused and has been removed from the WiX rules as of swiftlang/swift-installer-scripts#347. Simplify the invocation.
compnerd
added a commit
to compnerd/swift-build
that referenced
this pull request
Nov 20, 2024
Remove the use of the `DEVTOOLS_ROOT` property when building the installer MSIs. References to this have been removed from the WiX projects as of swiftlang/swift-installer-scripts#347.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the Windows build has evolved, we have built up a complete toolchain image and removed the need for the separate
DEVTOOLS_ROOT. This simplifies the packaging manifest and associated MSBuild files.