Skip to content

improve docker setup #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2021
Merged

improve docker setup #36

merged 1 commit into from
Oct 13, 2021

Conversation

shahmishal
Copy link
Member

Reverts #35

@shahmishal
Copy link
Member Author

We can merge this change once CI job is updated to use the Docker compose.

@tomerd
Copy link
Contributor

tomerd commented Oct 8, 2021

ci would need to be changed to do the following:

cd <path>
# update the base image if needed
docker-compose build --pull
# build the package in <path>/.output
docker-compose run build

@shahmishal shahmishal merged commit 280e478 into main Oct 13, 2021
@shahmishal shahmishal deleted the revert-35-revert-32-fix/docker-setup branch October 13, 2021 06:57
@tomerd
Copy link
Contributor

tomerd commented Oct 19, 2021

@tachoknight lmk if you want me to suggest similar PRs for fedora, or you want to do it yourself.

@tomerd tomerd changed the title Revert "Revert "improve docker setup"" improve docker setup Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shahmishal @tomerd