Skip to content

[WiX] Remove an outdated educational note from Windows packaging. #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

hborla
Copy link
Member

@hborla hborla commented Mar 4, 2025

I'm removing this note in swiftlang/swift@f1492fe; the restriction was lifted in SE-0362.

Starting in Swift 6.2, educational note identifiers should be stable and should not be removed in later toolchains. However, Swift 6.2 will be the first toolchain version to make that promise, so it's okay to clean up this educational note now.

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose that this is fine, though, I think that we could leave it in on main and only remove it on the release/6.1 branch as main is 6.2-dev.

We need to make sure this makes it to release/6.1 though.

@hborla
Copy link
Member Author

hborla commented Mar 4, 2025

I suppose that this is fine, though, I think that we could leave it in on main and only remove it on the release/6.1 branch as main is 6.2-dev.

I'm confused. I'm only removing the educational note on main, not on release/6.1.

@compnerd
Copy link
Member

compnerd commented Mar 4, 2025

Oh, sorry, I misunderstood the commit message. The first toolchain to guarantee the stability of edunotes is 6.2, not this feature. Ignore the message, LGTM!

@hborla hborla merged commit c69bbdf into swiftlang:main Mar 4, 2025
@hborla hborla deleted the remove-educational-note branch March 4, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants