Skip to content

Update the RPM spec files to support release/5.6 #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 11, 2022
Merged

Update the RPM spec files to support release/5.6 #80

merged 4 commits into from
Mar 11, 2022

Conversation

shahmishal
Copy link
Member

No description provided.

@shahmishal
Copy link
Member Author

cc: @tachoknight @tomerd @futurejones

As we are getting closer to releasing Swift 5.6, I updated the spec files to include new repos and drop patch file.

@tachoknight Did you get a chance to look into using metadata file for Fedora?

tomerd
tomerd reviewed Mar 11, 2022
View reviewed changes
tomerd
tomerd reviewed Mar 11, 2022
View reviewed changes
tomerd
tomerd reviewed Mar 11, 2022
View reviewed changes
Copy link
Contributor

@tomerd tomerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool. one question / discussion point re. versioning of .0 releases

@shahmishal shahmishal requested a review from tomerd March 11, 2022 02:12
shahmishal
shahmishal commented Mar 11, 2022
View reviewed changes
@tomerd
Copy link
Contributor

tomerd commented Mar 11, 2022

nice 🚀

@tachoknight
Copy link
Contributor

I tried to build on Fedora 35 with the spec file but there's a couple of issues, one is minor and I created this PR to fix it. The build doesn't currently work with the latest tag (5.6-DEVELOPMENT-SNAPSHOT-2022-03-02-a) so I guess I'll wait till 5.6 is released to make sure it builds.

@shahmishal
Copy link
Member Author

I tried to build on Fedora 35 with the spec file but there's a couple of issues, one is minor and I created this PR to fix it. The build doesn't currently work with the latest tag (5.6-DEVELOPMENT-SNAPSHOT-2022-03-02-a) so I guess I'll wait till 5.6 is released to make sure it builds.

Thank you for the fix!

@shahmishal shahmishal merged commit ce2cdc6 into main Mar 11, 2022
@shahmishal shahmishal deleted the test-swift-5.6 branch March 11, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomerd tomerd tomerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shahmishal @tomerd @tachoknight