Add integration test for building Swift benchmarks with SwiftPM #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gottesmm
reviewed
Oct 29, 2018
| // | ||
| // RUN: rm -rf %t.dir | ||
| // RUN: mkdir -p %t.dir/ | ||
| // RUN: cp -R %{swift_benchmarks_path} %t.dir/benchmark |
There was a problem hiding this comment.
Why copy? Why not just use the benchmark path? Other than that if everything works, LGTM.
gottesmm
reviewed
Oct 29, 2018
aciidgh
force-pushed
the
build-benchmarks-with-swiftpm
branch
from
4ee850c to
29bea3f
Compare
gottesmm
reviewed
Oct 29, 2018
aciidgh
force-pushed
the
build-benchmarks-with-swiftpm
branch
from
29bea3f to
ab70fea
Compare
|
Looks beautiful. Run a test and lets get this party started. |
|
Running a cross-repo test here: swiftlang/swift#19142 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.