Use the SwiftPM overrides consistently #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartbit
force-pushed
the
swiftpm-overrides
branch
from
ffec8d1 to
87ae4fc
Compare
|
@aciidb0mb3r does that look reasonable to you? |
aciidgh
reviewed
Mar 5, 2019
| @@ -10,7 +10,7 @@ | |||
| # RUN: git clone https://github.com/apple/example-package-dealer %t.dir/dealer | |||
|
|
|||
| # RUN: rm -rf %t.dir/dealer/.build | |||
| # RUN: %{swift} build --package-path %t.dir/dealer 2>&1 | tee %t.build-log | |||
| # RUN: %{swift-build} --package-path %t.dir/dealer 2>&1 | tee %t.build-log | |||
There was a problem hiding this comment.
I don't think we should do this because then we're not testing swift's subtool invocation.
There was a problem hiding this comment.
We're testing the swift's subtool invocation by default, when not passing swiftpm_build.
There was a problem hiding this comment.
Ah okay. This repo doesn't have PR testing so maybe create a dummy PR on swift and then do a cross-repo testing?
|
Any news? |
aciidgh
approved these changes
Mar 19, 2019
|
Got tests passing on Swift with a dummy PR: Should be ready to merge. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need this PR in to help me work on
swift-integration-testsmore efficiently