Update tests to support more types of SwiftPM build messages #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aciidb0mb3r what do you think? |
aciidgh
reviewed
Mar 23, 2019
| @@ -4,7 +4,7 @@ | |||
| // RUN: rm -rf %t.dir | |||
| // RUN: mkdir -p %t.dir | |||
| // RUN: cp -r %S/foo %t.dir/ | |||
| // RUN: %{swift-test} --package-path %t.dir/foo --enable-code-coverage -v 2>&1 | tee %t.build-log | |||
| // RUN: %{swift} test --package-path %t.dir/foo --enable-code-coverage -v 2>&1 | tee %t.build-log | |||
There was a problem hiding this comment.
This line is a revert from the previous PR: this specific test can't work correctly against a custom SwiftPM binary because it expects to find code coverage information in the same folder. It basically only works with a toolchain.
There was a problem hiding this comment.
Cool, feel free to test and merge this!
|
One minor comment but looks good, thanks! |
aciidgh
approved these changes
Mar 23, 2019
|
@aciidb0mb3r I've tested this PR in swiftlang/swift#23417. Can you merge it for me? I don't have merge rights on this repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow merging the SwiftPM build animation without failing those tests: swiftlang/swift-package-manager#2050