Make sure apple/swift#34023, which removes /usr/lib/swift/linux from the RUNPATH of several Swift libraries, stays that way #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Michael suggested a better way to do this, I'll update it. |
…rom the RUNPATH of several Swift libraries, stays that way.
|
Alright, redid this to make sure that rpath was removed, rather than checking that only Ready to test now. |
|
Can someone run the CI for this? |
|
Ping @gottessmm, ready to go. |
|
Whoops, pinging @gottesmm, got your nick wrong before, this is ready for CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recommended by @gottesmm, needs to be tested with that pull.