Add cmake build for Windows #7
Conversation
Sources/CLMDB/CMakeLists.txt
Outdated
| @@ -0,0 +1,7 @@ | |||
| add_library(CLMDB STATIC | |||
There was a problem hiding this comment.
Why explicitly static? Why not drop STATIC and let the user control the library type?
|
BTW, what is the difference between this and #6? I can unmark that as a draft if that is helpful. |
I don't think there is a difference at all, really. If that PR is ready then I'm fine with using it instead. I'm really not all that familiar with cmake. So, I'm mostly doing this by trial and error and looking at other projects. |
|
@matthewbastien yes, that PR has been ready, the only reason it was marked as a draft is because I didn't have the DocC change ready to go yet (I have a CMake based build of DocC which was significantly reducing the build times and somewhat on the size as well). |
|
Awesome, thank you! I'm closing this PR in favour of yours. |
This is tracked by rdar://139431575 as a part of swiftlang/vscode-swift#562
Add a cmake build of swift-lmdb for Windows that can be used by swiftlang/indexstore-db to match the version of LMDB used by swift-docc. This enables SourceKit-LSP to use swift-docc as a dependency to fulfill documentation requests on behalf of the VS Code Swift extension.