-
Notifications
You must be signed in to change notification settings - Fork 221
Fix/remove argument-parser #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/remove argument-parser #6
Conversation
Thanks for this! It looks like this shared some overlap with #13 - would you mind reworking this on top of the current |
7923aa9
to
cc99a57
Compare
@QuietMisdreavus I went over the current status of the main branch and what we wanted to do. Many of the changes I added were already included in the main branch, so they turned out to be simple changes. Please review this pull request. |
@swift-ci please test |
@@ -22,9 +22,6 @@ let package = Package( | |||
.library( | |||
name: "Markdown", | |||
targets: ["Markdown"]), | |||
.executable( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@griffin-stewie Thanks for doing this! Do you mind updating the base Package.swift
while we're at it here? I think we should try to keep them consistent as much as possible.
…ntParser is not added unnecessarily when used it as a library.
6a36906
to
986cb14
Compare
@ethan-kusters |
@swift-ci please test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thank you so much @griffin-stewie!
Summary
Remove the executable "markdown-tool" from the product so that ArgumentParser is not added unnecessarily when used it as a library.
In my case, I added swift-markdown to my CLI tool that it uses swift-argument-parser v1.0.1 then I got the following error.
This PR will fix this issue.
Dependencies
none.
Testing
All tests passed my local environment.
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/test
script and it succeeded