Skip to content

Fix broken links #1076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2025
Merged

Fix broken links #1076

merged 1 commit into from
Jun 9, 2025

Conversation

federicobucchi
Copy link
Member

Motivation:

Some links give 404

Result:

Links are fixed

alexandersandberg
alexandersandberg reviewed Jun 9, 2025
View reviewed changes
Copy link
Member

@alexandersandberg alexandersandberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the fix here? It looks like a variable is just being renamed?

The links seem to work for me already as well. Where exactly are they broken?

@federicobucchi
Copy link
Member Author

What's the fix here? It looks like a variable is just being renamed?

The links seem to work for me already as well. Where exactly are they broken?

If you try Development Snapshots in https://www.swift.org/install/linux/debian/12/ clicking on Download (x86_64) it gives 404. In the url there is -aarch64.

This is happening because the import of {% include install/_older-releases.md platform=include.platform %} uses the same variable name that happends -aarch64.

Changing the name, we avoid the conflict

alexandersandberg
alexandersandberg approved these changes Jun 9, 2025
View reviewed changes
Copy link
Member

@alexandersandberg alexandersandberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see! Appreciate the additional detail. Fix looks good 👍

@federicobucchi federicobucchi merged commit f9c9ef4 into main Jun 9, 2025
4 checks passed
@federicobucchi federicobucchi deleted the fb/fix-404-link branch June 9, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandersandberg alexandersandberg alexandersandberg approved these changes

@0xTim 0xTim Awaiting requested review from 0xTim 0xTim is a code owner

@davelester davelester Awaiting requested review from davelester davelester is a code owner

@daveverwer daveverwer Awaiting requested review from daveverwer daveverwer is a code owner

@dempseyatgithub dempseyatgithub Awaiting requested review from dempseyatgithub dempseyatgithub is a code owner

@kaishin kaishin Awaiting requested review from kaishin kaishin is a code owner

@shahmishal shahmishal Awaiting requested review from shahmishal shahmishal is a code owner

@timsneath timsneath Awaiting requested review from timsneath timsneath is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@federicobucchi @alexandersandberg