Skip to content

[Articles] Add Emacs article. #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 7, 2024
Merged

Conversation

al45tair
Copy link
Contributor

Add an article showing how to get started with Swift using Emacs.

rdar://127610658

Add an article showing how to get started with Swift using Emacs.

rdar://127610658
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. The article needs the Jekyll metadata to be able to do a proper review though as I can't see the generated content without it (no HTML page is created)

@al45tair al45tair requested a review from 0xTim June 5, 2024 10:35
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good - some queries around code blocks and we should probably have a bigger discussion around how to link to installing Swift

@al45tair
Copy link
Contributor Author

al45tair commented Jun 6, 2024

@swift-ci Please test

@al45tair al45tair requested a review from 0xTim June 6, 2024 15:21
@federicobucchi federicobucchi mentioned this pull request Jun 6, 2024
Rather than providing guidance on installing Swift here, link to the
installation page on the Swift website.
@al45tair al45tair requested a review from bnbarham June 7, 2024 11:33
@al45tair
Copy link
Contributor Author

al45tair commented Jun 7, 2024

@swift-ci Please test

@al45tair al45tair merged commit 73a872f into swiftlang:main Jun 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants