Skip to content

Commit 085165e

Browse files
authored
Fix PackageCollectionsTests.testUpdateAuthTokens (#3479)
Motivation: Test crashed in CI: #3478 (comment) Modification: Use `ThreadSafeKeyValueStore` to as backing store of `authTokens`.
1 parent 12a6e82 commit 085165e

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

Tests/PackageCollectionsTests/PackageCollectionsTests.swift

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
import Foundation
1212
import XCTest
1313

14+
import Basics
1415
@testable import PackageCollections
1516
import PackageModel
1617
import SourceControl
@@ -19,9 +20,8 @@ import TSCUtility
1920

2021
final class PackageCollectionsTests: XCTestCase {
2122
func testUpdateAuthTokens() throws {
22-
var authTokens: [AuthTokenType: String]? = [:]
23-
24-
let configuration = PackageCollections.Configuration(authTokens: { authTokens })
23+
let authTokens = ThreadSafeKeyValueStore<AuthTokenType, String>()
24+
let configuration = PackageCollections.Configuration(authTokens: { authTokens.get() })
2525
let storage = makeMockStorage()
2626
defer { XCTAssertNoThrow(try storage.close()) }
2727

@@ -38,7 +38,7 @@ final class PackageCollectionsTests: XCTestCase {
3838
XCTAssertEqual(0, githubMetadataProvider.configuration.authTokens()?.count)
3939
}
4040

41-
authTokens![.github("github.test")] = "topsekret"
41+
authTokens[.github("github.test")] = "topsekret"
4242

4343
// Check that authTokens change is propagated to PackageMetadataProvider
4444
XCTAssertEqual(1, packageCollections.configuration.authTokens()?.count)
@@ -47,7 +47,7 @@ final class PackageCollectionsTests: XCTestCase {
4747
return XCTFail("Expected GitHubPackageMetadataProvider")
4848
}
4949
XCTAssertEqual(1, githubMetadataProvider.configuration.authTokens()?.count)
50-
XCTAssertEqual(authTokens, githubMetadataProvider.configuration.authTokens())
50+
XCTAssertEqual(authTokens.get(), githubMetadataProvider.configuration.authTokens())
5151
}
5252
}
5353

0 commit comments

Comments
 (0)