fix silent crash when output from compiler is too large #3478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivation: silent crashes, confused uers changes: * change the order in swiftCompilerOutputParser such that print the stdout happens before any parsing attenpts are made * contraint the parsing attempts to output < 10k, since otherwise they struggle to complete rdar://77558631
|
@swift-ci please smoke test |
tomerd
added
the
ready
cc @yim-lee seems like some race condition there? code looks fine tbh and TSan also happy 🤔 |
|
@swift-ci please smoke test macOS |
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
May 7, 2021
Motivation: Test crashed in CI: swiftlang#3478 (comment) Modification: Use `ThreadSafeKeyValueStore` to as backing store of `authTokens`.
I suppose it doesn't hurt to use |
neonichu
approved these changes
May 7, 2021
yim-lee
added a commit
that referenced
this pull request
May 7, 2021
Motivation: Test crashed in CI: #3478 (comment) Modification: Use `ThreadSafeKeyValueStore` to as backing store of `authTokens`.
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
May 7, 2021
Motivation: Test crashed in CI: swiftlang#3478 (comment) Modification: Use `ThreadSafeKeyValueStore` to as backing store of `authTokens`.
tomerd
added a commit
to tomerd/swift-package-manager
that referenced
this pull request
May 7, 2021
motivation: silent crashes, confused uers changes: * change the order in swiftCompilerOutputParser such that print the stdout happens before any parsing attenpts are made * contraint the parsing attempts to output < 10k, since otherwise they struggle to complete rdar://77558631
tomerd
added a commit
to tomerd/swift-package-manager
that referenced
this pull request
May 7, 2021
motivation: silent crashes, confused uers changes: * change the order in swiftCompilerOutputParser such that print the stdout happens before any parsing attenpts are made * contraint the parsing attempts to output < 10k, since otherwise they struggle to complete rdar://77558631
This was referenced May 7, 2021
tomerd
added a commit
that referenced
this pull request
May 7, 2021
tomerd
pushed a commit
that referenced
this pull request
May 10, 2021
Motivation: Test crashed in CI: #3478 (comment) Modification: Use `ThreadSafeKeyValueStore` to as backing store of `authTokens`.
tomerd
added a commit
that referenced
this pull request
May 14, 2021
bitjammer
pushed a commit
to bitjammer/swift-package-manager
that referenced
this pull request
Jul 23, 2021
Motivation: Test crashed in CI: swiftlang#3478 (comment) Modification: Use `ThreadSafeKeyValueStore` to as backing store of `authTokens`.
bitjammer
pushed a commit
to bitjammer/swift-package-manager
that referenced
this pull request
Jul 23, 2021
motivation: silent crashes, confused uers changes: * change the order in swiftCompilerOutputParser such that print the stdout happens before any parsing attenpts are made * contraint the parsing attempts to output < 10k, since otherwise they struggle to complete rdar://77558631
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: silent crashes, confused uers
changes: