Skip to content

[5.5] fix silent crash when output from compiler is too large #3483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2021

Conversation

tomerd
Copy link
Contributor

@tomerd tomerd commented May 7, 2021

bring #3478 to 5.5

motivation: silent crashes, confused uers

changes:
* change the order in swiftCompilerOutputParser such that print the stdout happens before any parsing attenpts are made
* contraint the parsing attempts to output < 10k, since otherwise they struggle to complete

rdar://77558631
@tomerd
Copy link
Contributor Author

tomerd commented May 7, 2021

@swift-ci please test

Copy link
Contributor

@abertelrud abertelrud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomerd tomerd merged commit daab77a into swiftlang:release/5.5 May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants