gracefully fail workspace state loading when duplicate entries found (#3974)

motivation: some older versions of SwiftPM wrote duplicate entries into workspace-state.json which can cause a crash due to use of Dictionary::uniquingKeysWith

changes:
* do not use Dictionary::uniquingKeysWith for non-santized input such as workspace state
* add tests

rdar://86857825

Author: tomerd

Sources/Workspace/ManagedArtifact.swift

@@ -115,10 +115,22 @@ extension Workspace {
             AnyCollection(self.artifactMap.values.lazy.flatMap{ $0.values })
         }
 
-        init(_ artifacts: [ManagedArtifact] = []) {
+        init() {
+            self.artifactMap = [:]
+        }
+
+        init(_ artifacts: [ManagedArtifact]) throws {
             let artifactsByPackagePath = Dictionary(grouping: artifacts, by: { $0.packageRef.identity })
-            self.artifactMap = artifactsByPackagePath.mapValues{ artifacts in
-                Dictionary(uniqueKeysWithValues: artifacts.map{ ($0.targetName, $0) })
+            self.artifactMap = try artifactsByPackagePath.mapValues{ artifacts in
+                // rdar://86857825 do not use Dictionary(uniqueKeysWithValues:) as it can crash the process when input is incorrect such as in older versions of SwiftPM
+                var map = [String: ManagedArtifact]()
+                for artifact in artifacts {
+                    if map[artifact.targetName] != nil {
+                        throw StringError("binary artifact for '\(artifact.targetName)' already exists in managed artifacts")
+                    }
+                    map[artifact.targetName] = artifact
+                }
+                return map
             }
         }
 

Sources/Workspace/ManagedDependency.swift

@@ -171,11 +171,21 @@ extension Workspace.ManagedDependency: CustomStringConvertible {
 extension Workspace {
     /// A collection of managed dependencies.
     final public class ManagedDependencies {
-        // FIXME: this should be identity based
         private var dependencies: [PackageIdentity: ManagedDependency]
 
-        init(_ dependencies: [ManagedDependency] = []) {
-            self.dependencies = Dictionary(uniqueKeysWithValues: dependencies.map{ ($0.packageRef.identity, $0) })
+        init() {
+            self.dependencies = [:]
+        }
+
+        init(_ dependencies: [ManagedDependency]) throws {
+            // rdar://86857825 do not use Dictionary(uniqueKeysWithValues:) as it can crash the process when input is incorrect such as in older versions of SwiftPM
+            self.dependencies = [:]
+            for dependency in dependencies {
+                if self.dependencies[dependency.packageRef.identity] != nil {
+                    throw StringError("\(dependency.packageRef.identity) already exists in managed dependencies")
+                }
+                self.dependencies[dependency.packageRef.identity] = dependency
+            }
         }
 
         public subscript(identity: PackageIdentity) -> ManagedDependency? {

Sources/Workspace/WorkspaceState.swift

@@ -96,12 +96,12 @@ fileprivate struct WorkspaceStateStorage {
                 let v4 = try self.decoder.decode(path: self.path, fileSystem: self.fileSystem, as: V4.self)
                 let dependencies = try v4.object.dependencies.map{ try Workspace.ManagedDependency($0) }
                 let artifacts = try v4.object.artifacts.map{ try Workspace.ManagedArtifact($0) }
-                return (dependencies: .init(dependencies), artifacts: .init(artifacts))
+                return try (dependencies: .init(dependencies), artifacts: .init(artifacts))
             case 5:
                 let v5 = try self.decoder.decode(path: self.path, fileSystem: self.fileSystem, as: V5.self)
                 let dependencies = try v5.object.dependencies.map{ try Workspace.ManagedDependency($0) }
                 let artifacts = try v5.object.artifacts.map{ try Workspace.ManagedArtifact($0) }
-                return (dependencies: .init(dependencies), artifacts: .init(artifacts))
+                return try (dependencies: .init(dependencies), artifacts: .init(artifacts))
             default:
                 throw StringError("unknown 'WorkspaceStateStorage' version '\(version.version)' at '\(self.path)'")
             }