gracefully fail workspace state loading when duplicate entries found #3974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivation: some older versions of SwiftPM wrote duplicate entries into workspace-state.json which can cause a crash due to use of Dictionary::uniquingKeysWith changes: * do not use Dictionary::uniquingKeysWith for non-santized input such as workspace state * add tests rdar://86857825
|
@swift-ci please smoke test |
tomerd
added
the
ready
abertelrud
approved these changes
Jan 5, 2022
tomerd
added a commit
to tomerd/swift-package-manager
that referenced
this pull request
Jan 5, 2022
…wiftlang#3974) motivation: some older versions of SwiftPM wrote duplicate entries into workspace-state.json which can cause a crash due to use of Dictionary::uniquingKeysWith changes: * do not use Dictionary::uniquingKeysWith for non-santized input such as workspace state * add tests rdar://86857825
tomerd
added a commit
that referenced
this pull request
Jan 5, 2022
…3974) (#3976) motivation: some older versions of SwiftPM wrote duplicate entries into workspace-state.json which can cause a crash due to use of Dictionary::uniquingKeysWith changes: * do not use Dictionary::uniquingKeysWith for non-santized input such as workspace state * add tests rdar://86857825
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: some older versions of SwiftPM wrote duplicate entries into workspace-state.json which can cause a crash due to use of Dictionary::uniquingKeysWith
changes:
rdar://86857825