Skip to content

Commit 8439932

Browse files
authored
update CommandTaskTracker to match llbuild's reporting of CustomTasks (#4294) (#4296)
motivation: adjust SwiftPM to llbuild reporting of task progress, which now includes custom tasks changes: increment finished tasks count based on the commandStatusChanged event instead of the commandFinished event rdar://84883732
1 parent 4346366 commit 8439932

File tree

1 file changed

+1
-10
lines changed

1 file changed

+1
-10
lines changed

Sources/Build/BuildOperationBuildSystemDelegateHandler.swift

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -729,7 +729,7 @@ fileprivate struct CommandTaskTracker {
729729
case .isUpToDate:
730730
self.totalCount -= 1
731731
case .isComplete:
732-
break
732+
self.finishedCount += 1
733733
@unknown default:
734734
assertionFailure("unhandled command status kind \(kind) for command \(command)")
735735
break
@@ -741,15 +741,6 @@ fileprivate struct CommandTaskTracker {
741741
self.onTaskProgressUpdateText?(progressTextValue, targetName)
742742

743743
self.latestFinishedText = progressTextValue
744-
745-
switch result {
746-
case .succeeded, .skipped:
747-
self.finishedCount += 1
748-
case .cancelled, .failed:
749-
break
750-
default:
751-
break
752-
}
753744
}
754745

755746
mutating func swiftCompilerDidOutputMessage(_ message: SwiftCompilerMessage, targetName: String) {

0 commit comments

Comments
 (0)