update CommandTaskTracker to match llbuild's reporting of CustomTasks #4294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivation: adjust SwiftPM to llbuild reporting of task progress, which now includes custom tasks changes: increment finished tasks count based on the commandStatusChanged event instead of the commandFinished event rdar://84883732
|
@swift-ci smoke test |
|
cc @BenchR267 |
abertelrud
approved these changes
Apr 13, 2022
There was a problem hiding this comment.
Looks reasonable to me, though I would not want just my review on this as I'm not that familiar with the llbuild callbacks. This seems like it's predicated on having the .isComplete status be true for both the .succeeded and .skipped results — if so, then this makes sense.
|
this was suggested by @BenchR267 based on changes done to llbuild |
BenchR267
approved these changes
Apr 14, 2022
tomerd
added a commit
to tomerd/swift-package-manager
that referenced
this pull request
Apr 14, 2022
…swiftlang#4294) motivation: adjust SwiftPM to llbuild reporting of task progress, which now includes custom tasks changes: increment finished tasks count based on the commandStatusChanged event instead of the commandFinished event rdar://84883732
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: adjust SwiftPM to llbuild reporting of task progress, which now includes custom tasks
changes: increment finished tasks count based on the commandStatusChanged event instead of the commandFinished event
rdar://84883732