fixup

Author: tomerd

Sources/PackageLoading/Diagnostics.swift

@@ -127,17 +127,6 @@ extension Basics.Diagnostic {
             localized variants will never be chosen
             """)
     }
-
-    static func missingDefaultLocalizationResource(
-        resource: String,
-        targetName: String,
-        defaultLocalization: String
-    ) -> Self {
-        .warning("""
-            resource '\(resource)' in target '\(targetName)' is missing the default localization \
-            '\(defaultLocalization)'; the default localization is used as a fallback when no other localization matches
-            """)
-    }
 }
 
 extension ObservabilityMetadata {

Sources/PackageLoading/TargetSourcesBuilder.swift

@@ -172,7 +172,6 @@ public struct TargetSourcesBuilder {
         diagnoseConflictingResources(in: resources)
         diagnoseCopyConflictsWithLocalizationDirectories(in: resources)
         diagnoseLocalizedAndUnlocalizedVariants(in: resources)
-        diagnoseMissingDevelopmentRegionResource(in: resources)
         diagnoseInfoPlistConflicts(in: resources)
         diagnoseInvalidResource(in: target.resources)
 
@@ -322,30 +321,6 @@ public struct TargetSourcesBuilder {
         }
     }
 
-    private func diagnoseMissingDevelopmentRegionResource(in resources: [Resource]) {
-        // We can't diagnose anything here without a default localization set.
-        guard let defaultLocalization = self.defaultLocalization else {
-            return
-        }
-
-        // rdar://86297221
-        // There is no need to validate for english, because the string key is already in english
-        if self.defaultLocalization == "en" {
-            return
-        }
-
-        let localizedResources = resources.lazy.filter({ $0.localization != nil && $0.localization != "Base" })
-        let resourcesByBasename = Dictionary(grouping: localizedResources, by: { $0.path.basename })
-        for (basename, resources) in resourcesByBasename {
-            if !resources.contains(where: { $0.localization == defaultLocalization }) {
-                self.observabilityScope.emit(.missingDefaultLocalizationResource(
-                    resource: basename,
-                    targetName: target.name,
-                    defaultLocalization: defaultLocalization))
-            }
-        }
-    }
-
     private func diagnoseInfoPlistConflicts(in resources: [Resource]) {
         for resource in resources {
             if resource.destination == RelativePath("Info.plist") {

Tests/PackageLoadingTests/TargetSourcesBuilderTests.swift

@@ -490,6 +490,8 @@ class TargetSourcesBuilderTests: XCTestCase {
         }
     }
 
+    // rdar://86297221
+    // There is no need to validate localization exists for default localization
     func testMissingDefaultLocalization() throws {
         let target = try TargetDescription(name: "Foo", resources: [
             .init(rule: .process(localization: .none), path: "Resources"),
@@ -509,15 +511,7 @@ class TargetSourcesBuilderTests: XCTestCase {
 
         do {
             build(target: target, defaultLocalization: "fr", toolsVersion: .v5_3, fs: fs) { _, _, _, _, identity, kind, path, diagnostics in
-                testDiagnostics(diagnostics) { result in
-                    let diagnostic = result.check(
-                        diagnostic: .contains("resource 'Icon.png' in target 'Foo' is missing the default localization 'fr'"),
-                        severity: .warning
-                    )
-                    XCTAssertEqual(diagnostic?.metadata?.packageIdentity, identity)
-                    XCTAssertEqual(diagnostic?.metadata?.packageKind, kind)
-                    XCTAssertEqual(diagnostic?.metadata?.targetName, target.name)
-                }
+                XCTAssertNoDiagnostics(diagnostics)
             }
         }