Update SystemModules.md to succeed on OS X 10.11 #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -177,7 +177,7 @@ And run it: | |||
|
|
|||
| --- | |||
|
|
|||
| Please note that on Ubuntu 15.10 the above steps fail with: | |||
| Please note that on some platforms, the above steps fail with: | |||
|
|
|||
| <module-includes>:1:10: note: in file included from <module-includes>:1: | |||
| #include "/usr/include/jpeglib.h" | |||
|
These instructions are also/mostly for Linux where the system packager will be installing to |
|
Don't reference |
|
Done. |
|
Great, thank you. Can we squash these changes? I'm sorry to ask as it is tedious, but there are many effects and emails when I merge and people prefer singular histories where appropriate. |
El Capitan's System Integrity Protection prevents the user from installing anything in `/usr/include` or `/usr/lib`, so use `/usr/local` instead, which is also where Homebrew installs `jpeg`. Also remove the statement about Homebrew’s jpeglib.h being correct because that's false.
|
No problem at all, rebased and squashed. |
mxcl
added a commit
that referenced
this pull request
Jan 21, 2016
Update SystemModules.md to succeed on OS X 10.11
aciidgh
pushed a commit
to aciidgh/swift-package-manager
that referenced
this pull request
Jan 11, 2019
[BuildSystem] Add support for directory signatures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
El Capitan's System Integrity Protection prevents the user from installing
anything in
/usr/includeor/usr/lib, so use/usr/localinstead, which isalso where Homebrew installs
jpeg.Also remove the statement about Homebrew’s jpeglib.h being correct
because that's false.