Fixes to enable swift section objects #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxcl
added a commit
that referenced
this pull request
Feb 18, 2016
Fixes to enable swift section objects
aciidgh
pushed a commit
to aciidgh/swift-package-manager
that referenced
this pull request
Jan 11, 2019
…ransactions <rdar://problem/25014088> [XCBuild] Cross process locking for shared build state files
MaxDesiatov
pushed a commit
to MaxDesiatov/swift-package-manager
that referenced
this pull request
Jul 6, 2020
[pull] swiftwasm from master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the new section objects changes comes online swiftlang/swift#1157 swiftc adds section marker objects into the link. As swiftc is only being used as a source of arguments to clang++ while bootstrapping swiftpm, and all .o's are filtered out, these objects are being dropped. This change ads an exception to that filter so that they are preserved.
This change should have no effect on the current functioning of the bootstrap, and can be applied prior to the referenced pull request.
cc/ @gribozavr @tienex