Skip to content

Refactor Build/describe() with Buildable protocol #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2016

Conversation

aciidgh
Copy link
Contributor

@aciidgh aciidgh commented Feb 23, 2016

No description provided.

@aciidgh aciidgh changed the title Refactor Build/describe() with Builable protocol Refactor Build/describe() with Buildable protocol Feb 23, 2016
@mxcl
Copy link
Contributor

mxcl commented Feb 23, 2016

@swift-ci please test

@aciidgh
Copy link
Contributor Author

aciidgh commented Feb 24, 2016

Any reason why it is setup to run All the tests and not only swiftpm tests?

@aciidgh
Copy link
Contributor Author

aciidgh commented Feb 25, 2016

@mxcl can you run CI again on this, it should pass now

@mxcl
Copy link
Contributor

mxcl commented Feb 26, 2016

@swift-ci please test

@mxcl
Copy link
Contributor

mxcl commented Feb 26, 2016

@shahmishal is there a way to get @swift-ci to only run SwiftPM tests? Sorry if you documented this, I cannot find the docs.

@modocache
Copy link
Contributor

This would save a massive amount of time for swift-corelibs-xctest as well.

@shahmishal
Copy link
Member

@mxcl Yes, I can update the job to use specific preset for swiftPM. Please email me the preset (build-script) Jenkins job should use for testing PR for swiftPM on OS X and Linux. Thanks!

@modocache We could also do the same thing for swift-corelibs-xctest. Thanks!

mxcl added a commit that referenced this pull request Feb 26, 2016
Refactor Build/describe() with Buildable protocol
@mxcl mxcl merged commit 6b85ded into swiftlang:master Feb 26, 2016
@aciidgh aciidgh deleted the patch-6 branch February 27, 2016 09:48
@modocache
Copy link
Contributor

@shahmishal The preset I added in swiftlang/swift#1533 is perfect for XCTest--it skips the CMark and Swift tests, so it's pretty fast. Thanks anyway, though!

aciidgh added a commit to aciidgh/swift-package-manager that referenced this pull request Jan 11, 2019
[BuildSystem] Fix a race between build() and cancel()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants