-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Throw error if debug.yaml
not found
#153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Is there a reason to not automatically run I'd probably propose to automatically run build as the first step of test. Or is there a reason not to? |
agreed, |
@czechboy0 we may change it. As it stands things are more flexible if you can control when the build happens entirely. |
@@ -24,6 +24,8 @@ do { | |||
setenv("SPM_INSTALL_PATH", dir.build, 0) | |||
|
|||
let yamlPath = Path.join(dir.build, "debug.yaml") | |||
if !yamlPath.exists { throw Error.DebugYAMLNotFound } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
guard
seems more appropriate to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
return "build the package using `swift build` before running tests" | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's no newline at the end of this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@mxcl Makes sense. The way I think of it is in Xcode, the "easier" action is Run and Test, which actually mean Build+Run and Build+Test. Then you can trigger Run Without Building & Test Without Building manually, but that's more work. |
Throw error if `debug.yaml` not found
[Xcode] Update llbuild scheme.
Shows error this error if
swift test
is run beforeswift build
instead of