Replace the deprecated CountableRange with Range #1542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
We need to maintain compatibility with Swift 4.0 in Basic and Utility |
hartbit
force-pushed
the
countablerange-warning
branch
from
5328798 to
bc54cdf
Compare
|
@aciidb0mb3r I added swift version checks |
aciidgh
reviewed
Mar 22, 2018
| public typealias Indices = CountableRange<Int> | ||
| #endif |
There was a problem hiding this comment.
@jrose-apple is this check enough to not break compatibility with 4.0?
There was a problem hiding this comment.
Should be fine, but shouldn't that be checking for 4.1, not 4.2? Yes, should be fine.
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.