Add an option to not delete TemporaryFile on dealloc #1625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aciidgh
reviewed
Jun 26, 2018
| file.fileHandle.seek(toFileOffset: 0) | ||
| // Read the contents. | ||
| let contents = try? file.fileHandle.readFileContents() | ||
| XCTAssertEqual(contents, "foobarbaz") |
There was a problem hiding this comment.
This test could be simplified I think. We can write data in the do block and then just read it outside the block using the FileSystem .
There was a problem hiding this comment.
Hmm I kept consistent with the other tests in this file, do you think they should all be changed?
There was a problem hiding this comment.
I think there was a reason to do that for other tests but anyway it was just a nitpick. LGTM!
aciidgh
reviewed
Jun 26, 2018
| filePath = file.path | ||
| } | ||
| // File should not be deleted. | ||
| XCTAssertTrue(isFile(filePath)) |
There was a problem hiding this comment.
We should also remove the temporary file before exiting this test.
|
@swift-ci please smoke test |
|
CI green \o/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's sometimes useful to create a temp file but keep it around for a little bit longer, instead of automatically deleting it on dealloc.
TemporaryDirectoryalready has a similar option.