Skip to content

pass fd to PackageDescription while parsing manifests instead of using SWIFT_DUMP_PACKAGE #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 9, 2016

Conversation

aciidgh
Copy link
Contributor

@aciidgh aciidgh commented Mar 3, 2016

No description provided.

@mxcl
Copy link
Contributor

mxcl commented Mar 3, 2016

Looks good. I am currently waiting on the swift-3-api-guidelines merge before merging anything new.

@mxcl
Copy link
Contributor

mxcl commented Mar 5, 2016

I'm going to start merging everything, as I hoped the swift 3 apis would be merged this week, but it looks like it will be longer.

@mxcl
Copy link
Contributor

mxcl commented Mar 8, 2016

@swift-ci Please test

@aciidgh
Copy link
Contributor Author

aciidgh commented Mar 8, 2016

/home/buildnode/jenkins/workspace/swift-package-manager-PR-Linux/swiftpm/Sources/ManifestParser/Manifest+parse.swift:74:13: error: use of unresolved identifier 'fclose'
    defer { fclose(fp) }
            ^~~~~~
<unknown>:0: error: build had 1 command failures

This did not error for me on OSX and Ubuntu 15.10
CI looks like to be on 14.04, will check.

@aciidgh
Copy link
Contributor Author

aciidgh commented Mar 8, 2016

This is weird, It works for me on Ubuntu 14.04 too.
Latest toolchain

Swift version 3.0-dev (LLVM b361b0fc05, Clang 11493b0f62, Swift 24a0c3de75)
Target: x86_64-unknown-linux-gnu

@mxcl
Copy link
Contributor

mxcl commented Mar 8, 2016

Probably would be fixed if you import func libc.fclose

@aciidgh
Copy link
Contributor Author

aciidgh commented Mar 8, 2016

I figured but weird that CI errors out where as nothing on local

@aciidgh
Copy link
Contributor Author

aciidgh commented Mar 8, 2016

@mxcl trigger CI please

@mxcl
Copy link
Contributor

mxcl commented Mar 9, 2016

@swift-ci Please test

@aciidgh
Copy link
Contributor Author

aciidgh commented Mar 9, 2016

CI succeeded merging

aciidgh added a commit that referenced this pull request Mar 9, 2016
pass fd to PackageDescription while parsing manifests instead of using SWIFT_DUMP_PACKAGE
@aciidgh aciidgh merged commit 989f373 into swiftlang:master Mar 9, 2016
@aciidgh aciidgh deleted the pass_fd branch March 9, 2016 02:17
aciidgh pushed a commit to aciidgh/swift-package-manager that referenced this pull request Jan 11, 2019
Previously, we were incrementing the pointer with the first `res.second++`, so the next part of the if statement would see the character after that.

This extracts that code, fixes the issue and adds unit tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants