-
Notifications
You must be signed in to change notification settings - Fork 1.4k
pass fd to PackageDescription while parsing manifests instead of using SWIFT_DUMP_PACKAGE #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks good. I am currently waiting on the swift-3-api-guidelines merge before merging anything new. |
I'm going to start merging everything, as I hoped the swift 3 apis would be merged this week, but it looks like it will be longer. |
@swift-ci Please test |
This did not error for me on OSX and Ubuntu 15.10 |
This is weird, It works for me on Ubuntu 14.04 too.
|
Probably would be fixed if you |
I figured but weird that CI errors out where as nothing on local |
@mxcl trigger CI please |
@swift-ci Please test |
CI succeeded merging |
pass fd to PackageDescription while parsing manifests instead of using SWIFT_DUMP_PACKAGE
Previously, we were incrementing the pointer with the first `res.second++`, so the next part of the if statement would see the character after that. This extracts that code, fixes the issue and adds unit tests.
No description provided.