Add 'PseudoTerminal' to 'TestSupport' #1720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aciidgh
reviewed
Aug 1, 2018
| @@ -12,46 +12,10 @@ import XCTest | |||
| import Utility | |||
| import SPMLibc | |||
| @testable import Basic | |||
| @testable import TestSupport | |||
There was a problem hiding this comment.
We should make the class public instead of doing a testable import
aciidgh
reviewed
Aug 3, 2018
| // Make sure to read the complete output before checking it. | ||
| pty.close() |
There was a problem hiding this comment.
We shouldn't close these fds at the same time. We should keep the separate closeSlave() and closeMaster() methods and change close() method to call those method in succession.
There was a problem hiding this comment.
Oh I see. Fixed!
aciidgh
reviewed
Aug 3, 2018
| // Make sure to read the complete output before checking it. | ||
| pty.closeSlave() |
There was a problem hiding this comment.
This diff is no longer required, right?
There was a problem hiding this comment.
Ugh sorry, my bad checking. Fixed!
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 'PseudoTerminal' to 'TestSupport' so it can be shared across different test targets
[ @aciidb0mb3r suggestion ]