Improving test tool diagnostics #1721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JhonnyBillM
commented
Aug 3, 2018
JhonnyBillM
commented
- Added DiagnosticsEngine parameter to TestRunner and ParallelTestRunner.
- Added emitting errors with DiagnosticsEngine.
- Formatted TestRunner init and calls to improve readability.
aciidgh
reviewed
Aug 3, 2018
Sources/Commands/SwiftTestTool.swift
Outdated
| @@ -446,18 +458,28 @@ final class TestRunner { | |||
|
|
|||
| // The toolchain to use. | |||
| private let toolchain: UserToolchain | |||
|
|
|||
| /// Diagnostics Engine to emit diagnostics | |||
There was a problem hiding this comment.
Please end the comments with punctuation. Same for the comment below.
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.