Skip to content

[SR-8459] fix --generate-linuxmain when testing subclasses #1722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 4, 2018

Conversation

JhonnyBillM
Copy link
Contributor

  • Replaced __allTests by __<className>
  • Updated the tests to fit this new naming method

Bug report by @aciidb0mb3r : https://bugs.swift.org/browse/SR-8459

@@ -62,7 +62,7 @@ final class LinuxMainGenerator {
for klass in module.classes.lazy.sorted(by: { $0.name < $1.name }) {
stream <<< "\n"
stream <<< "extension " <<< klass.name <<< " {" <<< "\n"
stream <<< indent(4) <<< "static let __allTests = [" <<< "\n"
stream <<< indent(4) <<< "static let __\(klass.name) = [" <<< "\n"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets use __allTests__\(klass.name))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Done.

@aciidgh
Copy link
Contributor

aciidgh commented Aug 3, 2018

@swift-ci smoke test

Copy link
Contributor

@aciidgh aciidgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🎉

@aciidgh aciidgh merged commit 6d37f25 into swiftlang:master Aug 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants