Skip to content

Remove extraneous #if os checks when using JSONEncoder #1803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2018

Conversation

aciidgh
Copy link
Contributor

@aciidgh aciidgh commented Oct 6, 2018

No description provided.

@aciidgh
Copy link
Contributor Author

aciidgh commented Oct 6, 2018

@swift-ci smoke test

Copy link
Contributor

@jakepetroules jakepetroules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh :)

@aciidgh
Copy link
Contributor Author

aciidgh commented Oct 6, 2018

@swift-ci smoke test

@jakepetroules
Copy link
Contributor

By the way, why still using "OSX" and not "macOS" for #available? Do we still have to build with an older version of Swift?

@aciidgh
Copy link
Contributor Author

aciidgh commented Oct 6, 2018

"meh" Maybe the Swift compiler emit a warning ;)

@aciidgh aciidgh merged commit 236451e into swiftlang:master Oct 9, 2018
@aciidgh aciidgh deleted the remove-extra-hash-if branch October 9, 2018 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants