Add release configuration #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great stuff. Probably I should try to add some tests for the project generation before merging this however. |
|
If you fix the merge we can CI this and get it merged. I added a preliminary regression test yesterday so now I'm happy to get this merged. |
AquaGeek
force-pushed
the
release-configuration
branch
from
82a5185 to
751b72a
Compare
|
Rebased |
|
The failure is correct. |
AquaGeek
force-pushed
the
release-configuration
branch
from
751b72a to
4d0acf2
Compare
|
Fixed the test. Sorry about that. |
|
@swift-ci Please test |
|
np, I added the test after your PR. Deliberately because I wanted something to validate that nothing had broken. Sorry back! :) |
aciidgh
pushed a commit
to aciidgh/swift-package-manager
that referenced
this pull request
Jan 11, 2019
[LLVM] Add LLVM import for Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.