Skip to content

[bootstrap] Extract dependency graph from manifest #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2016
Merged

[bootstrap] Extract dependency graph from manifest #187

merged 1 commit into from
Mar 11, 2016

Conversation

mxcl
Copy link
Contributor

@mxcl mxcl commented Mar 10, 2016

Python is not my forte, so please improve.

/cc @ddunbar

@aciidgh
Copy link
Contributor

aciidgh commented Mar 10, 2016

swiftpm is becoming the coolest kid in town ✋

@@ -179,24 +180,65 @@ class Target(object):
str(bool(self.is_library)).lower()), file=output)
print(file=output)

def parse_manifest():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment here that this is actually reading Swift might be nice.

I think a corresponding comment in our Package.swift that we do this here would be good.

@mxcl
Copy link
Contributor Author

mxcl commented Mar 11, 2016

@swift-ci Please test

mxcl added a commit that referenced this pull request Mar 11, 2016
[bootstrap] Extract dependency graph from manifest
@mxcl mxcl merged commit 1fe7638 into swiftlang:master Mar 11, 2016
@mxcl mxcl deleted the parse_deps_in_bootstrap branch March 12, 2016 00:18
aciidgh pushed a commit to aciidgh/swift-package-manager that referenced this pull request Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants