[Xcodeproj] Add -DSWIFT_PACKAGE=1 to the C/C++ preprocessor defines #1910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aciidgh
force-pushed
the
dswift-package-1
branch
from
299ae06 to
0ad3dd3
Compare
It was already set for swift, but needed to be added for C/C++/etc. to match how this works for a command-line `swift build` invocation. Also fixes a subtle bug in inherited resolution for build settings.
aciidgh
force-pushed
the
dswift-package-1
branch
from
0ad3dd3 to
3697ed8
Compare
|
@swift-ci smoke test |
benlangmuir
commented
Dec 6, 2018
|
Verified this generates an xcodeproj with the expected definitions of SWIFT_PACKAGE and DEBUG for both Swift and C. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was already set for swift, but needed to be added for C/C++/etc. to
match how this works for a command-line
swift buildinvocation.