Improve external dependency discovery logic #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| void cool() { | ||
| foo(); | ||
| } |
There was a problem hiding this comment.
Very minor thing but this is missing a line break at the end of the file :)
|
Really, we shouldn't be detecting this, we should specify explicitly external deps at a higher level. |
|
Yeah I understand this is a total hack to begin with, I can try fixing it next week. |
|
@mxcl Fixed, Review/CI |
|
@swift-ci Please test |
|
@swift-ci Please test |
|
LGTM, please merge when you're done. |
aciidgh
pushed a commit
to aciidgh/swift-package-manager
that referenced
this pull request
Jan 11, 2019
…tion Improved build cancellation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages can have few different layouts, the logic to detect if a dep is an external dep was not handling all the cases.