[bootstrap] Update bootstrap utility to be Python 3 compatible

[RLovelett]

• Enforce a UTF-8 encoded string when reading Package.swift
• Convert map to list in Python 3

Fixes SR-934

[modocache]

nit-pick: Let's keep this list of imports in alphabetical order. How about putting this between import argparse and import errno?

[RLovelett]

No problem; pushed that change up.

[aciidgh]

I think this made Python 2 incompatible, is that intended? I am getting this error with default python 2.7.10

Traceback (most recent call last):
  File "Utilities/bootstrap", line 237, in <module>
    targets = parse_manifest()
  File "Utilities/bootstrap", line 198, in parse_manifest
    manifest_data = open(os.path.join(g_project_root, "Package.swift"), encoding='utf-8', errors='strict').read()
TypeError: 'errors' is an invalid keyword argument for this function

I was able to bootstrap using :
$ Python3 Utilities/bootstrap

[RLovelett]

That certainly wasn't intended. I tested it on my Mac (which has Python 2.7.11) and on my Linux box (which has Python 3.5.1). Both are able to bootstrap just fine for me.

When I submitted the line it looked like

manifest_data = codecs.open(os.path.join(g_project_root, "Package.swift"), encoding='utf-8', errors='strict').read()

the line you show in that error message looks like

manifest_data = open(os.path.join(g_project_root, "Package.swift"), encoding='utf-8', errors='strict').read()

Note that the codecs. module is not referenced in your error output. Perhaps that is just the error output "cleaning" it up or something. Just incase can you make sure it says codecs. in your actual script?

[aciidgh]

not sure what happened, I deleted and re-fetched the master; codecs. seems to be back and its working now

[ddunbar]

If you see it again see if you can verify exactly what version of Python that is.

On Mar 14, 2016, at 5:58 PM, Ankit Agarwal [email protected] wrote:

not sure what happened, I deleted and re-fetched the master; codecs. seems to be back and its working now

—
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub:
#197 (comment) #197 (comment)

[aciidgh]

I think it was some issue with git and maybe was related to 6008cef

[ddunbar]

Ah, yes that makes sense.

[mxcl]

This was my bad, though not because of this commit, I merged another python PR manually as it was conflicting with this one and I merged it badly.

Then pushed a fix.