Remove posix calls in TemporaryFile.swift #2087
Conversation
walter-erquinigo
changed the title
walter-erquinigo
changed the title
|
This looks good to me, and the removeItem that this uses just got implemented on Windows today (swiftlang/swift-corelibs-foundation#2117). |
| return prefix + "." + randomMiddleString + suffix | ||
| } | ||
|
|
||
| func mkstemps(dir: AbsolutePath, prefix: String, suffix: String) throws -> AbsolutePath { |
There was a problem hiding this comment.
I am a little nervous about this. I think we should at least use mkstemps where it's available.
There was a problem hiding this comment.
I think that the logic is quite straightforward.
Why are you nervous about it? We can discuss it
There was a problem hiding this comment.
My team changed my mind, i'll implement this in a posix way and additionally a windows specific way
|
@compnerd is this still relevant given your recent work for Windows support? |
|
I don't think that this is relevant any longer. @a20012251 if you think that this is still relevant, please rebase and reopen the PR. |
This implements a portable version of mkstemps and mkdtemp so that the code also works on Windows. This simplified the code considerably