Skip to content

[Tests] Refactored parsing of scheme from repo URL, added Collection tests #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 6, 2016
Merged

[Tests] Refactored parsing of scheme from repo URL, added Collection tests #209

merged 2 commits into from
Apr 6, 2016

Conversation

czechboy0
Copy link
Member

  • refactored parsing of scheme from repo URL
  • moved Array utils to Collection utils
  • added Collection tests
  • moved all allTests functions into one file (Utilities modules only for now), previously they were in FileTests which was hard to find

gribozavr
gribozavr reviewed Mar 19, 2016
View reviewed changes
Sources/Utility/CollectionExtensions.swift
}
}

//FIXME figure out why it doesn't work when Iterator.Element == Equatable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Iterator.Element : Equatable

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thank you!!!

@mxcl
Copy link
Contributor

mxcl commented Apr 2, 2016

I appreciate the effort, but this wasn't merged earlier because it is really several PRs. The additional tests are most interesting to me, and I'm happy to have a general Collection utils organization. The rest is not really desired, though I certainly can see the improvements, I'd rather improve the tests in general, but I'm waiting on the Linux test generation work.

I understand URL.scheme is not general, but I dislike repoScheme, and it's not as though this is public API in Cocoa or anything.

czechboy0 added 2 commits April 2, 2016 14:16
@czechboy0
[Tests] Refactored parsing of scheme from repo URL, moved Array utils…
8f6cf43 
… to Collection utils, added Collection tests, moved all allTests functions into one file, previously they were in FileTests which was hard to find
@czechboy0
Merge branch 'master' into hd/tests/string_utils
bb98759 
# Conflicts:
#	Tests/Utility/FileTests.swift
@czechboy0
Copy link
Member Author

@mxcl I renamed repoScheme back to scheme, so those changes are reverted. What's left is the repo scheme parsing refactoring and the new tests and moved manifests. Are those the changes you wanted to keep? If not, please let me know which part exactly you have reservations about.

@mxcl
Copy link
Contributor

mxcl commented Apr 5, 2016

@swift-ci Please test

@czechboy0
Copy link
Member Author

@mxcl @swift-ci seems to be in a lazy mood

@mxcl
Copy link
Contributor

mxcl commented Apr 5, 2016

@swift-ci Please test

@czechboy0
Copy link
Member Author

Hitting the same WatchKit test failure as everyone else.

@czechboy0
Copy link
Member Author

@mxcl Please rerun CI

@mxcl
Copy link
Contributor

mxcl commented Apr 6, 2016

@swift-ci Please test

@czechboy0
Copy link
Member Author

\o/

@mxcl mxcl merged commit ecd595a into swiftlang:master Apr 6, 2016
aciidgh pushed a commit to aciidgh/swift-package-manager that referenced this pull request Jan 11, 2019
@ddunbar
Merge pull request swiftlang#209 from ddunbar/directory-tree-structur…
d91cf5e 
…e-case-fix

[BuildSystem] Update a couple places for new node type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@czechboy0 @mxcl @gribozavr