Skip to content

Move code for finding test targets into PackageGraph #2109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions Sources/PackageGraph/PackageGraph.swift
Original file line number Diff line number Diff line change
Expand Up @@ -101,4 +101,36 @@ public struct PackageGraph {
self.reachableTargets = reachableTargets
self.reachableProducts = reachableProducts
}

/// Computes a map from each executable target in any of the root packages to the corresponding test targets.
public func computeTestTargetsForExecutableTargets() -> [ResolvedTarget: [ResolvedTarget]] {
var result = [ResolvedTarget: [ResolvedTarget]]()

let rootTargets = rootPackages.map({ $0.targets }).flatMap({ $0 })

// Create map of test target to set of its direct dependencies.
let testTargetDepMap: [ResolvedTarget: Set<ResolvedTarget>] = {
let testTargetDeps = rootTargets.filter({ $0.type == .test }).map({
($0, Set($0.dependencies.compactMap({ $0.target })))
})
return Dictionary(uniqueKeysWithValues: testTargetDeps)
}()

for target in rootTargets where target.type == .executable {
// Find all dependencies of this target within its package.
let dependencies = try! topologicalSort(target.dependencies, successors: {
$0.dependencies.compactMap({ $0.target }).map(ResolvedTarget.Dependency.target)
}).compactMap({ $0.target })

// Include the test targets whose dependencies intersect with the
// current target's (recursive) dependencies.
let testTargets = testTargetDepMap.filter({ (testTarget, deps) in
!deps.intersection(dependencies + [target]).isEmpty
}).map({ $0.key })

result[target] = testTargets
}

return result
}
}
21 changes: 3 additions & 18 deletions Sources/Xcodeproj/SchemesGenerator.swift
Original file line number Diff line number Diff line change
Expand Up @@ -63,31 +63,16 @@ final class SchemesGenerator {

var schemes: [Scheme] = []

// Create map of test target to set of its direct dependencies.
let testTargetDepMap: [ResolvedTarget: Set<ResolvedTarget>] = {
let testTargetDeps = rootPackage.targets.filter({ $0.type == .test }).map({
($0, Set($0.dependencies.compactMap({ $0.target })))
})
return Dictionary(uniqueKeysWithValues: testTargetDeps)
}()
let testTargetsMap = graph.computeTestTargetsForExecutableTargets()

// Create one scheme per executable target.
for target in rootPackage.targets where target.type == .executable {
// Find all dependencies of this target within its package.
let dependencies = try! topologicalSort(target.dependencies, successors: {
$0.dependencies.compactMap({ $0.target }).map(ResolvedTarget.Dependency.target)
}).compactMap({ $0.target })

// Include the test targets whose dependencies intersect with the
// current target's (recursive) dependencies.
let testTargets = testTargetDepMap.filter({ (testTarget, deps) in
!deps.intersection(dependencies + [target]).isEmpty
}).map({ $0.key })
let testTargets = testTargetsMap[target]

schemes.append(Scheme(
name: target.name,
regularTargets: [target],
testTargets: testTargets
testTargets: testTargets ?? []
))
}

Expand Down