[swift-build] update swift build --init library tests format

[kostiakoval]

Update test to new format. The old format doesn't work on Linux any more.

run sb --init library in NewInit folder
This genere these File:

//LinuxMain.swift

import XCTest
@testable import NewInitTestSuite

XCTMain([
     testCase(NewInit.allTests),
])

//Tests/NewInit/NewInit.swift

import XCTest
@testable import NewInit

class NewInit: XCTestCase {

    func testExample() {
        // This is an example of a functional test case.
        // Use XCTAssert and related functions to verify your tests produce the correct results.
    }

}
extension NewInit {
    static var allTests : [(String, NewInit -> () throws -> Void)] {
        return [
            ("testExample", testExample),
        ]
    }
}

Notes:

The only think I don't like here that NewInit TestCase class and file has the same name as source file.
I think it would be nice to add a suffix, like: NewInitTests or NewInitTestCase

I see that in SwiftPM we use both naming conventions.

[kostiakoval]

@modocache Do you have any thoughts about files and classes naming for tests?

[mxcl]

I agree, a TestCase suffix seems like a good idea.

[kostiakoval]

After thinking for some time about it, I think TestCase prefix is not a good naming.
Maybe we should discuss it in mailing-list instead.

My reasoning:

1. It's to verbose and duplicate naming information from XCTestCase
2. It's not consistent with Xcode tests naming. Xcode uses Tests suffix
3. It's specific for XCTestCase. It's not generic and has not so strong meaning when using with other test framework, like Quick
4. swift-test tool uses Test Case naming for a particular test. That's correct in my opinion.

Test Case '-[GetTestSuite.VersionGraphTests testComplexVersionRestrictedGraph]' passed (0.001 seconds).

Conclusion
I prefer Tests prefix. It's clearly says that this file and class contains test, it's more generic and consistent with existing tools. :)

[aciidgh]

I know executable tests are not supported right now but is it possible to somehow add a test to catch this in future?

[kostiakoval]

Yes definitely! I even think I know how do that :)

• invoke "swift build --init",
• run build for generated project
• run test.

But I thought it would be in next PR. This is broken on Linux so I would prefer to get it merged now

[mxcl]

You mean a Tests suffix?

[modocache]

The convention for XCTestCase tests has been {SubjectUnderTest}Tests. Why not generate an NewInitTests here?

[mxcl]

The convention for XCTestCase tests has been {SubjectUnderTest}Tests. Why not generate an NewInitTests here?

Suits me.

[kostiakoval]

@mxcl Done

[mxcl]

@swift-ci Please test

[mxcl]

LGTM