Print warning if a module not present for a product, error out if zer… #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
Needs a regression test at least. |
Will add |
…o modules in a product
|
@mxcl Rebased and added tests |
|
@swift-ci Please test |
|
OSX failed for some reason, @mxcl CI again? |
|
@swift-ci please test |
|
Seems reasonable to me but @mxcl's area... |
|
@mxcl please review before this gets conflicted 😂 |
aciidgh
pushed a commit
to aciidgh/swift-package-manager
that referenced
this pull request
Jan 11, 2019
All of these are actually valid characters in filenames, so we should allow them to appear in .d files. <rdar://problem/32670559> Failure building '=>.swift' (error reading dependency file: unexpected character in prerequisites)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…o modules in a product
Fixes https://bugs.swift.org/browse/SR-1064