add posix time formatting #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| libc.time(&time) | ||
| let result = libc.ctime(&time) | ||
|
|
||
| return String(cString: result) |
There was a problem hiding this comment.
Shouldn't return type be Double
There was a problem hiding this comment.
okay I see its not unix ts
kostiakoval
force-pushed
the
posix-time
branch
3 times, most recently
from
7b5f1bd to
99f893a
Compare
|
After studying this topic I think it would be better to Use Thread Safe Functions |
|
Probably, yes. Currently we are single thread, but that will change as Swift gains concurrency primitives. |
|
Done, use TS functions and added error handling. |
|
@swift-ci Please test |
|
test are passing, shall we merge it? |
|
Please 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add posix functions for getting and formatting time.
This function is required in RP #122.