Skip to content

Conditionally import FoundationXML for upcoming Foundation changes #2257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2019
Merged

Conditionally import FoundationXML for upcoming Foundation changes #2257

merged 1 commit into from
Jul 31, 2019

Conversation

aciidgh
Copy link
Contributor

@aciidgh aciidgh commented Jul 31, 2019

No description provided.

@aciidgh aciidgh mentioned this pull request Jul 31, 2019
Merged
@aciidgh
Copy link
Contributor Author

aciidgh commented Jul 31, 2019

/cc @millenomi

@aciidgh
Copy link
Contributor Author

aciidgh commented Jul 31, 2019

@swift-ci smoke test

@aciidgh
Copy link
Contributor Author

aciidgh commented Jul 31, 2019

Given our limited use case, I wonder if a dependency on FoundationXML (and thus libxml2) is worth it. Maybe I should just use regex instead.

@jakepetroules
Copy link
Contributor

Maybe I should just use regex instead.

NO, please don't. If we're parsing XML, let's use an actual XML parser.

@aciidgh aciidgh merged commit ad226ac into swiftlang:master Jul 31, 2019
@aciidgh aciidgh deleted the xmlstuff branch July 31, 2019 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakepetroules jakepetroules jakepetroules approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aciidgh @jakepetroules